-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added global time element #1232
base: main
Are you sure you want to change the base?
Added global time element #1232
Conversation
I added the global time element, please notify for any changes required. |
The comment you got at #1231 (comment) on the previous version of this PR still applies:
When a PR needs changes, update the existing PR rather than close it and make a new one. That way discussion doesn't restart from scratch. For help, see the Zulip Git guide. |
Hello @gnprice , |
Before asking for review, you need to take a look at your own changes and self-review. This deletes a bunch of localizations, and it makes hundreds of lines of formatting changes. None of that is related to the feature this PR is described as being about. So the same feedback you were given before still applies. |
fb4e848
to
de2c0e1
Compare
2609713
to
a75e921
Compare
90f437a
to
c28e1a4
Compare
Hello @gnprice , |
This isn't a coherent sequence of well-explained changes: For examples of mergeable commits, please browse the commit history: https://github.com/zulip/zulip-mobile/blob/main/docs/howto/git.md#2-the-secret-to-using-git-log--p You're welcome to ask Git questions in |
Hello @chrisbobbe , |
No need to make a new PR; just force-push your new branch here. |
I had added the global time element
Related #1215
issue.1215.mp4