-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial prototype implementation #8
base: main
Are you sure you want to change the base?
Conversation
b06d804
to
9b0ecae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is nice 👍, now will check tests and do some testing
LGTM, works the same way in IntelliJ IDEA |
Please, add |
Can we replace |
|
8aa2a54
to
a6e1b12
Compare
From the repo perspective, it would be better to separate the actual solution between different folders. The implementation is intended to be supported both in VS Code and IntelliJ IDEA. Can I ask the team to bring all the VS Code related things into the "vscode-extension" folder? So that it would be a clear separation between the VS Code and IntelliJ IDEA parts in the future |
It is a good idea, I agree. |
@KUGDev I agree, that's why all the VS Code related parts already are part of the |
@msujew ok I see. Then the IntelliJ IDEA related stuff will go into the "packages" folder as well. Will the "extension" folder remain with the same name? Cause if we add the "plugin" folder, it would mean that we are going to provide IntelliJ IDEA plugin only. I guess, the "intellij-plugin" naming would be more appropriate, and to stay consistent, it would mean that for the VSCode extension the folder name "vscode-extension" would be more appropriate as well |
cfe3f94
to
d5bf1a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
1f0d1c2
to
cfcd5bf
Compare
cfcd5bf
to
6b5d434
Compare
aaae68e
to
183a00e
Compare
...s/IBM1747IS-Function-cannot-be-used-before-the-functions-descriptor-list-has-been-scanned.ts
Show resolved
Hide resolved
...IBM1388IE-NODESCRIPTOR-attribute-is-invalid-when-any-parameter-has-NONCONNECTED-attribute.ts
Show resolved
Hide resolved
...nguage/src/validation/messages/IBM1324IE-name-occurs-more-than-once-within-exports-clause.ts
Show resolved
Hide resolved
packages/language/src/validation/messages/IBM1295IE-sole-bound-specified.ts
Show resolved
Hide resolved
183a00e
to
91e9352
Compare
Co-authored-by: Benjamin Wilson <[email protected]> Co-authored-by: Markus Rudolph <[email protected]> Signed-off-by: Mark Sujew <[email protected]>
91e9352
to
4e07d32
Compare
This is an initial implementation of the PL/I language server using Langium. It supports most (as far as we can tell) of the base language. Missing prominent features: