Fix /server/environment endpoint for best ZSS route (v2) #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression from v2.10 caused app-server to send an empty object for the "agent" attribute on the /server/environment URL.
This attribute was used by the Desktop to determine the best route to ZSS. When missing, it causes the Desktop to reach ZSS through the app-server, as in the following network chain:
browser -> gateway -> app-server -> gateway -> zss
or when gateway is missing
browser -> app-server -> zss
The correct routing when the gateway is present should be
browser -> gateway -> zss
This PR restores that behavior by fixing the /server/environment URL so that the Desktop has the info necessary to find that more direct route.