Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setuptools <= 75.6.0. #292

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Allow setuptools <= 75.6.0. #292

merged 2 commits into from
Dec 19, 2024

Conversation

icemac
Copy link
Member

@icemac icemac commented Dec 18, 2024

zc.buildout is nowadays tested against this version. Maybe we addidtionally need a final release of zc.buildout as support for these newer versions is only in 4.0.0a1.

`zc.buildout` is nowadays tested against this version.
Maybe we addidtionally need a final release of `zc.buildout` as support
for these newer versions is only in `4.0.0a1`.
@icemac icemac requested a review from dataflake December 18, 2024 07:17
@icemac icemac self-assigned this Dec 18, 2024
@coveralls
Copy link

coveralls commented Dec 18, 2024

Pull Request Test Coverage Report for Build 12388781176

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 18.363%

Totals Coverage Status
Change from base Build 12388741547: 0.0%
Covered Lines: 164
Relevant Lines: 724

💛 - Coveralls

@icemac
Copy link
Member Author

icemac commented Dec 18, 2024

See also buildout/buildout#673

@icemac
Copy link
Member Author

icemac commented Dec 18, 2024

Hm, that setuptools version does not support Python 3.8 anymore. So I'd also suggest starting to drop support for that Python version. (I'd like to do this in a sepate PR.)

@icemac
Copy link
Member Author

icemac commented Dec 18, 2024

Hm, that setuptools version does not support Python 3.8 anymore. So I'd also suggest starting to drop support for that Python version. (I'd like to do this in a sepate PR.)

See #293

@dataflake
Copy link
Member

zc.buildout is nowadays tested against this version. Maybe we addidtionally need a final release of zc.buildout as support for these newer versions is only in 4.0.0a1.

I think it's fine. buildout/buildout#671 didn't make any code changes to zc.buildout so it should work with the current release.

@icemac
Copy link
Member Author

icemac commented Dec 19, 2024

Thank you for reviewing this PR. 😃

@icemac icemac merged commit d1a00d2 into master Dec 19, 2024
12 checks passed
@icemac icemac deleted the setuptools-75.6.0 branch December 19, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants