Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional check for safer_getattr #285

Merged
merged 6 commits into from
Aug 7, 2024
Merged

additional check for safer_getattr #285

merged 6 commits into from
Aug 7, 2024

Conversation

loechel
Copy link
Member

@loechel loechel commented Aug 5, 2024

add an additional check for potential breakout capability via Inspection Attributes Names in the provided safer_getattr method.

…ion Attributes Names in the provided safer_getattr method.
@loechel loechel requested review from icemac and d-maurer August 5, 2024 11:44
@loechel loechel self-assigned this Aug 5, 2024
CHANGES.rst Outdated Show resolved Hide resolved
Co-authored-by: Dieter Maurer <[email protected]>
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mixed in reformatting of the code makes it unneccessarily hard to review this PR. Please reduce it to the actual changes needed.

@loechel loechel requested a review from icemac August 6, 2024 10:15
@loechel
Copy link
Member Author

loechel commented Aug 6, 2024

@icemac I have undone the linting changes, please review again.

src/RestrictedPython/Guards.py Outdated Show resolved Hide resolved
@icemac icemac enabled auto-merge (squash) August 7, 2024 06:12
@icemac icemac disabled auto-merge August 7, 2024 06:29
@icemac icemac merged commit 57a2acb into master Aug 7, 2024
23 of 25 checks passed
@icemac icemac deleted the getattr branch August 7, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants