Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panoptes.js Experimental Auth: add signOut() #6591

Open
wants to merge 5 commits into
base: remove-pjc-experiment-pt3
Choose a base branch
from

Conversation

shaunanoordin
Copy link
Member

PR Overview

Package: Package: lib-panoptes-js
Part of: replacing PJC with Panoptes JS
Follows and requires: #6552

This PR continues the experiment to remove PJC from FEM. We now have the ability to Sign Out from the Zooniverse!

  • Experimental Auth: added signOut()
    • signOut() will sign the user out of the Panoptes server, and reset the data store. Returns true on success.
    • ⚠️ Note one difference in the behaviour of the new signOut() vs old PJC signOut.
      • New: if a user isn't signed in, signOut() exits with return false.
      • Old: if a user isn't signed in, signOut() throws an error.
      • I personally don't think attempting to sign out while not signed in is bad enough to throw an error, but I'm happy to discuss this. I may be missing actual use cases where thrown errors would be appropriate.
  • Dev server: new "sign out" button added, to manually trigger the action.

Status

Ready for internal team review.

Again, please note that the code is verbose on purpose.

For an overall overview of the auth, please see "Understanding Auth with Panoptes.js & PJC": https://docs.google.com/presentation/d/1KwqAjUcFa7QENV2N-qpDs7deILp_nIHl_K-ZBx8G9K4/edit (Zooniverse team only)

@shaunanoordin shaunanoordin requested a review from a team December 20, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant