refactor: builtins #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimoo
reviewed
Apr 12, 2024
|
|
||
| pub mod crypto; | ||
|
|
||
| pub static CRYPTO_MODULE: Lazy<BuiltinModule> = Lazy::new(|| { | ||
| let functions = parse_fn_sigs(&CRYPTO_FNS); |
There was a problem hiding this comment.
can you delete the parse_fn_sigs function now?
mimoo
approved these changes
Apr 12, 2024
| BUILTIN_FNS.get(&qualified.name) | ||
| } else { | ||
| self.functions.get(qualified) | ||
| } |
There was a problem hiding this comment.
I'm puzzled as to why this code existed before, I guess it was useless right?
There was a problem hiding this comment.
My understanding is it was trying to differentiate the crypto builtin functions and native functions.
But since both the builtins and natives are stored in the same place now, this code seem deprecated.
src/type_checker/mod.rs
Outdated
| @@ -154,8 +149,8 @@ impl TypeChecker { | |||
|
|
|||
| // initialize it with the standard library | |||
| let crypto_module = ModulePath::Absolute(UserRepo::new("std/crypto")); | |||
| for (fn_name, fn_info) in CRYPTO_MODULE.functions.iter() { | |||
| let qualified = FullyQualified::new(&crypto_module, fn_name); | |||
| for fn_info in crypto_fns().iter() { | |||
There was a problem hiding this comment.
btw you should be able to write for fn_info in crypto_fns() no?
mimoo
reviewed
Apr 12, 2024
src/stdlib/mod.rs
Outdated
| let functions = parse_fn_sigs(&CRYPTO_FNS); | ||
| BuiltinModule { functions } | ||
| }); | ||
|
|
||
| pub fn get_std_fn(submodule: &str, fn_name: &str, span: Span) -> Result<FnInfo> { |
There was a problem hiding this comment.
Is this function used anywhere? Maybe we can delete
There was a problem hiding this comment.
it seems no. may be dead code?
katat
force-pushed
the
refactor/builtins
branch
from
ded71f1 to
7e5c974
Compare
katat
force-pushed
the
refactor/builtins
branch
from
7e5c974 to
fc65b02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static and const builtins doesn't work for generic types. These changes are for adapting to different backends.