Upgrade to arkworks 0.4.0/2 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #138 |
mimoo
reviewed
Dec 15, 2024
Cargo.toml
Outdated
| @@ -32,8 +32,7 @@ camino = "1.1.1" # to replace Path and PathBuf | |||
| clap = { version = "4.0.5", features = ["derive"] } # CLI library | |||
| dirs = "4.0.0" # helper functions (e.g. getting the home directory) | |||
| itertools = "0.10.3" # useful iter traits | |||
| kimchi = { git = "https://github.com/o1-labs/proof-systems", rev = "a5d8883ddf649c22f38aaac122d368ecb9fa2230" } # ZKP - Dec 5th, 2023 revision | |||
| #kimchi = { git = "https://github.com/o1-labs/proof-systems", rev = "b9589626f834f9dbf9d587e73fd8176171231e90" } # ZKP | |||
| kimchi = { git = "https://github.com/o1-labs/proof-systems", rev = "483bd5bd918ebbc1d5e008ce892d7a0023b50ed1" } # ZKP | |||
There was a problem hiding this comment.
any reason for this 3-month old commit?
There was a problem hiding this comment.
No reason other than it was the commit referenced in #138. I checked this morning and upgrading to the latest version of kimchi only required a couple more changes, so I went ahead and made them
|
minimal changes :D nice, (cc @dmpierre I think you were stuck on this one) |
mimoo
reviewed
Dec 17, 2024
mimoo
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kimchi was upgraded to a newer version that uses Arkworks 0.4, and Arkworks dependencies were upgraded to match those used by Kimchi (either 0.4.0 or 0.4.2 depending).