server mode for visual debugging #215
Conversation
| @@ -116,6 +130,9 @@ pub fn cmd_build(args: CmdBuild) -> miette::Result<()> { | |||
|
|
|||
| println!("successfully built"); | |||
|
|
|||
| // server mode | |||
| handle.map(|h| h.join().unwrap()); | |||
There was a problem hiding this comment.
Since we don't use the return from the map function, maybe be better to this instead:
| handle.map(|h| h.join().unwrap()); | |
| if let Some(h) = handle { h.join().unwrap() } |
There was a problem hiding this comment.
what's the difference?
There was a problem hiding this comment.
then clippy won't throw warning :)
| @@ -184,7 +205,7 @@ fn produce_all_asts<B: Backend>(path: &PathBuf) -> miette::Result<(Sources, Type | |||
| let mut tast = TypeChecker::new(); | |||
|
|
|||
| // adding stdlib | |||
| add_stdlib(&mut sources, &mut tast, node_id)?; | |||
| add_stdlib(&mut sources, &mut tast, node_id, server_mode)?; | |||
There was a problem hiding this comment.
maybe it is better to create server_mode fields in nast/tast/mast structs? so we don't have to add server_mode as an argument everytime we call the functions?
There was a problem hiding this comment.
yeah I think we should have some sort of super Options struct so that we can manage all of these arguments that we pass in different places, and have it have a Default implementation as well as setters
|
I'll wait for you @katat to merge the init-stdlib PR first |
|
|
addresses #203
very primitive and clunky interface:
I run it this way in a noname project:
$ cargo run --manifest-path <noname_path>/Cargo.toml -- build --server-modethe changes are pretty straight forward:
--server-modeoption to the build commandindex.htmlpage on/