Feat/add arkwork witness and prover #1
Conversation
| @@ -0,0 +1,71 @@ | |||
| use ark_bls12_381::Bls12_381; | |||
There was a problem hiding this comment.
copied from mopro-ffi and did interface modification.
| @@ -0,0 +1,104 @@ | |||
| use ark_ec::pairing::Pairing; | |||
There was a problem hiding this comment.
copied from mopro-ffi/cricom/serialization.rs and removed ethereum related logics.
| let file = File::open(&zkey_path)?; | ||
| let mut reader = std::io::BufReader::new(file); | ||
| // check the prime in the header | ||
| // println!("{} {} {}", header.q, header.n8q, ark_bls12_381::Fq::MODULUS); |
There was a problem hiding this comment.
I think this can be removed
|
|
||
| #[test] | ||
| fn test_serialization_deserialization() { | ||
| let r1cs_path = "../test-vectors/circom/multiplier2.r1cs"; |
There was a problem hiding this comment.
can you also fix this test as well?
| ark-ec = { version = "0.5.0", default-features = false, features = ["parallel"] } | ||
| ark-ff = { version = "0.5.0", default-features = false, features = ["parallel", "asm"] } | ||
| ark-std = { version = "0.5.0", default-features = false, features = ["parallel"] } | ||
| ark-bn254 = { version = "0.5.0" } | ||
| ark-groth16 = { version = "0.5.0", default-features = false, features = ["parallel"] } | ||
| ark-poly = { version = "0.5.0", default-features = false, features = ["parallel"] } | ||
| ark-relations = { version = "0.5.1", default-features = false } | ||
| ark-serialize = { version = "0.5.0", default-features = false } | ||
| ark-bls12-381 = { version = "0.5.0" } | ||
| ark-ec = { version = "0.4.1", default-features = false, features = ["parallel"] } | ||
| ark-ff = { version = "0.4.0", default-features = false, features = ["parallel", "asm"] } | ||
| ark-std = { version = "0.4.0", default-features = false, features = ["parallel"] } | ||
| ark-bn254 = { version = "0.4.0" } | ||
| ark-groth16 = { version = "0.4.0", default-features = false, features = ["parallel"] } | ||
| ark-poly = { version = "0.4.0", default-features = false, features = ["parallel"] } | ||
| ark-relations = { version = "0.4", default-features = false } | ||
| ark-serialize = { version = "0.4.0", default-features = false } | ||
| ark-bls12-381 = { version = "0.4.0" } |
There was a problem hiding this comment.
can we upgrade the version?
or it fails to upgrade?
There was a problem hiding this comment.
No, we can't because of ark-circom, we're using our own branch
ark-circom = { git = "https://github.com/zkmopro/circom-compat.git", version = "0.1.0", branch = "wasm-delete", optional = true }
| num = { version = "0.4.3" } | ||
| num = { version = "=0.4.0" } |
There was a problem hiding this comment.
sometimes we have problem with the fixed package version
I think we can keep it like
num = { version = "0.4.0" }There was a problem hiding this comment.
Actually, I like fixed version more. Usually, version upgradation makes more issues. But in this PR, I just followed compiler's suggestion to make this version fixed. Will modify it back.
|
Hi @vivianjeng , if there is no major design issues in this PR, I'll add a |
No description provided.