forked from zeropoolnetwork/libzeropool-rs
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calldata V2 #80
Open
EvgenKor
wants to merge
24
commits into
develop
Choose a base branch
from
enhancement/memo-format
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Calldata V2 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2024
AllFi
reviewed
Feb 27, 2024
AllFi
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support decentralized relayer architecture the transaction calldata format should be changed to support new fields such as
proxy address
andprover fee
. The following major changes were introduced:TxOperator
entity to describe proxy and prover fees and proxy address.TxOperator
is a substitution forfee
field (libzkbob-rs
)create_tx
to creating universal transaction calldata for both versions (libzkbob-rs
)is_obsolete_pool
to theUserAccount
initializers to support old memo format (libzkbob-rs
,libzkbob-rs-wasm
)ExtraItem
struct to describe additional user artefacts for the transaction.ExtraItem
isn't implemented for now completely: it's a part of input transaction but will not be included in the output calldata (libzkbob-rs
)libzkbob-rs-wasm
)The following libraries versions will produced after the merging of this PR:
1.4.0
1.2.0
1.7.0
New calldata format described here as a draft
libzkbob-rs-wasm
library was published as a beta (single-thread, multi-theread) and using in the following chain: