Skip to content

Merge pull request #156 from AloeareV/add_macro_helpers #317

Merge pull request #156 from AloeareV/add_macro_helpers

Merge pull request #156 from AloeareV/add_macro_helpers #317

GitHub Actions / Clippy (MSRV) failed Jan 14, 2025 in 0s

Clippy (MSRV)

7 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 7
Warning 0
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check failure on line 407 in zaino-state/src/mempool.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unneeded `return` statement

error: unneeded `return` statement
   --> zaino-state/src/mempool.rs:407:23
    |
407 |             status => return Err(MempoolError::StatusError(StatusError(status))),
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `-D clippy::needless-return` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
    |
407 |             status => Err(MempoolError::StatusError(StatusError(status))),
    |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 123 in zaino-state/src/mempool.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

using `clone` on type `Hash` which implements the `Copy` trait

error: using `clone` on type `Hash` which implements the `Copy` trait
   --> zaino-state/src/mempool.rs:123:44
    |
123 |                         check_block_hash = chain_info.best_block_hash.clone();
    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `chain_info.best_block_hash`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check failure on line 108 in zaino-state/src/mempool.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

using `clone` on type `Hash` which implements the `Copy` trait

error: using `clone` on type `Hash` which implements the `Copy` trait
   --> zaino-state/src/mempool.rs:108:43
    |
108 |                         best_block_hash = chain_info.best_block_hash.clone();
    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `chain_info.best_block_hash`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `-D clippy::clone-on-copy` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`

Check failure on line 1806 in zaino-state/src/fetch.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `error::FetchServiceError`

error: useless conversion to the same type: `error::FetchServiceError`
    --> zaino-state/src/fetch.rs:1806:27
     |
1806 |             Err(e) => Err(e.into()),
     |                           ^^^^^^^^ help: consider removing `.into()`: `e`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 1801 in zaino-state/src/fetch.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `error::FetchServiceError`

error: useless conversion to the same type: `error::FetchServiceError`
    --> zaino-state/src/fetch.rs:1801:31
     |
1801 |                 Err(e) => Err(e.into()),
     |                               ^^^^^^^^ help: consider removing `.into()`: `e`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
     = note: `-D clippy::useless-conversion` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

Check failure on line 1446 in zaino-state/src/fetch.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`

error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
    --> zaino-state/src/fetch.rs:1446:17
     |
1446 |                 limit.and_then(|limit| Some(NoteCommitmentSubtreeIndex(limit))),
     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `limit.map(|limit| NoteCommitmentSubtreeIndex(limit))`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map

Check failure on line 390 in zaino-state/src/fetch.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`

error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
   --> zaino-state/src/fetch.rs:390:17
    |
390 |                 limit.and_then(|limit_index| Some(limit_index.0)),
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `limit.map(|limit_index| limit_index.0)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
    = note: `-D clippy::bind-instead-of-map` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::bind_instead_of_map)]`