Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump safely #36

Merged
merged 11 commits into from
Aug 5, 2024
Merged

Bump safely #36

merged 11 commits into from
Aug 5, 2024

Conversation

idky137
Copy link
Contributor

@idky137 idky137 commented Jul 18, 2024

This PR is preliminary work towards updating dependency versions. The desired version have been added to Cargo.tomls but the actual update will be done in a separate PR.

The majority of this pr is removing dependencies. In some places code has been added where required:

  • to remove LibRustZcash the CompactTcStreamer is now built locally.
  • to remove zebra primitive structs have been added to zingo-rpc::primitives.
  • zingo-testutils has been removed apart from code under the nym_poc feature flag, which is to be removed in full once a Nym enhanced zingolib build is complete.

Other work in this PR:

  • The Cargo.tomls have been restructured for readability.
  • errors have been moved into sub mods and NymError was created to handle Nym related error.
  • connect_to_node_get_info integration test was rewritten to use a zingo lightclient, simplifying dependency tree.

Two bugs in test code ware also fixed.

  • Adding a panic to the custom test panic handler fixed a bug where, if an auxiliary thread panicked, the whole test was shut down and passed. This now results in a test failure, showing the underlying panic info.
  • Due to the block cache not yet being implemented, get_block_range would sometimes timeout. The timeout duration was increased for get_block_range to handle this, however this should be fixed with the block cache.

@idky137 idky137 marked this pull request as ready for review July 19, 2024 17:27
@idky137 idky137 marked this pull request as draft July 24, 2024 10:50
@idky137 idky137 marked this pull request as ready for review July 26, 2024 15:41
@idky137 idky137 mentioned this pull request Aug 2, 2024
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review is superficial. This is a major refactor.

@zancas zancas merged commit 4c5d832 into zingolabs:dev Aug 5, 2024
3 of 12 checks passed
@idky137 idky137 deleted the bump_safely branch October 8, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants