Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact block cache pt2 #163

Merged
merged 9 commits into from
Jan 22, 2025
Merged

Conversation

idky137
Copy link
Contributor

@idky137 idky137 commented Jan 20, 2025

This is the second PR adding the internal compact block cache to the FetchService in zaino-state.

  • Updates Zaino's config files and example config (zindexer.toml) by adding the new options required for integrating the BlockCache into the FetchService.
  • Removes old (unused) config options.
  • Updates Zaino-Testutils TestManager to handle new config options.
  • Adds several review changes to the BlockCache.

The actual BlockCache integration will be done in the following PR.

@idky137 idky137 added the ZGM2 Issues that need to be resolved for the completion of the Zaino dev grant milestone 2 label Jan 20, 2025
@idky137 idky137 marked this pull request as ready for review January 22, 2025 14:43
@idky137 idky137 requested a review from AloeareV January 22, 2025 14:43
Copy link
Contributor

@AloeareV AloeareV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm noticing a lot of boilerplate in the tests, I think that is where I will focus next!

zaino-state/src/fetch.rs Show resolved Hide resolved
@AloeareV AloeareV merged commit 4017f95 into zingolabs:dev Jan 22, 2025
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZGM2 Issues that need to be resolved for the completion of the Zaino dev grant milestone 2
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants