Add macro helpers #156
Merged
Add macro helpers #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is brilliant! Are the methods that require more work the ones that take no input of the one that takes the streaming input? Could we update either the Looks really good though! If you have a preference on how to get the last methods working Im happy either way.. |
idky137
added
the
ZGM2
idky137
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds atop #153
@idky137 this doesn't yet work for the few service methods that don't pass their argument in to the dispatched function call. This shouldn't be too hard to extend...but I am worried that this macro makes this file too hard to read/modify, and I might want to rewrite it from scratch with a focus on something more readable. What do you think?