Skip to content

Merge pull request #152 from idky137/update_mempool #301

Merge pull request #152 from idky137/update_mempool

Merge pull request #152 from idky137/update_mempool #301

Triggered via push January 8, 2025 20:34
Status Failure
Total duration 1d 21h 21m 22s
Artifacts

ci.yml

on: push
Matrix: build-latest
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

19 errors and 8 warnings
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
Rustfmt
Process completed with exit code 1.
Code coverage
Process completed with exit code 1.
unneeded `return` statement: zaino-state/src/mempool.rs#L392
error: unneeded `return` statement --> zaino-state/src/mempool.rs:392:23 | 392 | status => return Err(MempoolError::StatusError(StatusError(status))), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 392 | status => Err(MempoolError::StatusError(StatusError(status))), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
using `clone` on type `Hash` which implements the `Copy` trait: zaino-state/src/mempool.rs#L108
error: using `clone` on type `Hash` which implements the `Copy` trait --> zaino-state/src/mempool.rs:108:44 | 108 | check_block_hash = chain_info.best_block_hash.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `chain_info.best_block_hash` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `Hash` which implements the `Copy` trait: zaino-state/src/mempool.rs#L93
error: using `clone` on type `Hash` which implements the `Copy` trait --> zaino-state/src/mempool.rs:93:43 | 93 | best_block_hash = chain_info.best_block_hash.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `chain_info.best_block_hash` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-D clippy::clone-on-copy` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`
useless conversion to the same type: `error::FetchServiceError`: zaino-state/src/fetch.rs#L1783
error: useless conversion to the same type: `error::FetchServiceError` --> zaino-state/src/fetch.rs:1783:27 | 1783 | Err(e) => Err(e.into()), | ^^^^^^^^ help: consider removing `.into()`: `e` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `error::FetchServiceError`: zaino-state/src/fetch.rs#L1778
error: useless conversion to the same type: `error::FetchServiceError` --> zaino-state/src/fetch.rs:1778:31 | 1778 | Err(e) => Err(e.into()), | ^^^^^^^^ help: consider removing `.into()`: `e` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`: zaino-state/src/fetch.rs#L1423
error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` --> zaino-state/src/fetch.rs:1423:17 | 1423 | limit.and_then(|limit| Some(NoteCommitmentSubtreeIndex(limit))), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `limit.map(|limit| NoteCommitmentSubtreeIndex(limit))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
casting to the same type is unnecessary (`u64` -> `u64`): zaino-state/src/fetch.rs#L902
error: casting to the same type is unnecessary (`u64` -> `u64`) --> zaino-state/src/fetch.rs:902:49 | 902 | ... height: height as u64, | ^^^^^^^^^^^^^ help: try: `height` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-D clippy::unnecessary-cast` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`
use of a fallible conversion when an infallible one could be used: zaino-state/src/fetch.rs#L892
error: use of a fallible conversion when an infallible one could be used --> zaino-state/src/fetch.rs:892:50 | 892 | ... Some(h) => h.try_into().map_err(|_e| { | ^^^^^^^^ help: use: `into` | = note: converting `u32` to `u64` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `-D clippy::unnecessary-fallible-conversions` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unnecessary_fallible_conversions)]`
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`: zaino-state/src/fetch.rs#L363
error: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` --> zaino-state/src/fetch.rs:363:17 | 363 | limit.and_then(|limit_index| Some(limit_index.0)), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `limit.map(|limit_index| limit_index.0)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map = note: `-D clippy::bind-instead-of-map` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::bind_instead_of_map)]`
Clippy (MSRV)
Clippy had exited with the 101 exit code
Test on ubuntu-latest
Process completed with exit code 101.
Test on macOS-latest
The job was canceled because "ubuntu-latest" failed.
Test on windows-latest
The job was canceled because "ubuntu-latest" failed.
Test on windows-latest
The operation was canceled.
Latest build on macOS-latest
This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.
Latest build on macOS-latest
This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.
Clippy (beta)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Rustfmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Code coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Clippy (MSRV)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Bitrot check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Intra-doc links
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Latest build on ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Test on ubuntu-latest
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636