error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> zaino-fetch/src/jsonrpc/response.rs:179:1 | 179 | impl Into<zebra_rpc::methods::GetBlockTrees> for GetBlockTrees { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `-D clippy::from-over-into` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::from_over_into)]` help: replace the `Into` implementation with `From<jsonrpc::response::GetBlockTrees>` | 179 ~ impl From<GetBlockTrees> for zebra_rpc::methods::GetBlockTrees { 180 ~ fn from(val: GetBlockTrees) -> Self { 181 ~ zebra_rpc::methods::GetBlockTrees::new(val.sapling(), val.orchard()) |

an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: zaino-fetch/src/jsonrpc/response.rs#L179

`to_string` applied to a type that implements `Display` in `format!` args: zaino-fetch/src/jsonrpc/error.rs#L39

error: `to_string` applied to a type that implements `Display` in `format!` args --> zaino-fetch/src/jsonrpc/error.rs:39:80 | 39 | tonic::Status::internal(format!("Error: JsonRPC Client Error: {}", self.to_string())) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `-D clippy::to-string-in-format-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::to_string_in_format_args)]`

`to_string` applied to a type that implements `Display` in `format!` args: zaino-fetch/src/jsonrpc/error.rs#L39

useless conversion to the same type: `chain::error::BlockCacheError`: zaino-fetch/src/chain/block.rs#L478

error: useless conversion to the same type: `chain::error::BlockCacheError` --> zaino-fetch/src/chain/block.rs:478:23 | 478 | Err(e) => Err(e.into()), | ^^^^^^^^ help: consider removing `.into()`: `e` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

useless conversion to the same type: `chain::error::BlockCacheError`: zaino-fetch/src/chain/block.rs#L478