Subtree roots RPCs #209
Triggered via pull request
November 13, 2024 19:11
Status
Failure
Total duration
14m 50s
Artifacts
–
ci.yml
on: pull_request
Bitrot check
8m 39s
Clippy (MSRV)
7m 50s
Clippy (beta)
16s
Code coverage
5m 12s
Intra-doc links
9m 43s
Rustfmt
48s
Matrix: build-latest
Matrix: test
Annotations
16 errors and 6 warnings
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
Rustfmt
Process completed with exit code 1.
|
Code coverage
Process completed with exit code 1.
|
Clippy (MSRV)
Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration
|
Clippy (MSRV)
Exiting due to clippy errors
|
Test on macOS-latest
Process completed with exit code 101.
|
Test on windows-latest
The job was canceled because "macOS-latest" failed.
|
Test on windows-latest
The operation was canceled.
|
Test on ubuntu-latest
The job was canceled because "macOS-latest" failed.
|
Test on ubuntu-latest
The operation was canceled.
|
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true:
zaino-fetch/src/jsonrpc/response.rs#L179
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> zaino-fetch/src/jsonrpc/response.rs:179:1
|
179 | impl Into<zebra_rpc::methods::GetBlockTrees> for GetBlockTrees {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-D clippy::from-over-into` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::from_over_into)]`
help: replace the `Into` implementation with `From<jsonrpc::response::GetBlockTrees>`
|
179 ~ impl From<GetBlockTrees> for zebra_rpc::methods::GetBlockTrees {
180 ~ fn from(val: GetBlockTrees) -> Self {
181 ~ zebra_rpc::methods::GetBlockTrees::new(val.sapling(), val.orchard())
|
|
`to_string` applied to a type that implements `Display` in `format!` args:
zaino-fetch/src/jsonrpc/error.rs#L39
error: `to_string` applied to a type that implements `Display` in `format!` args
--> zaino-fetch/src/jsonrpc/error.rs:39:80
|
39 | tonic::Status::internal(format!("Error: JsonRPC Client Error: {}", self.to_string()))
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `-D clippy::to-string-in-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::to_string_in_format_args)]`
|
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true:
zaino-fetch/src/jsonrpc/response.rs#L179
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> zaino-fetch/src/jsonrpc/response.rs:179:1
|
179 | impl Into<zebra_rpc::methods::GetBlockTrees> for GetBlockTrees {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-D clippy::from-over-into` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::from_over_into)]`
help: replace the `Into` implementation with `From<jsonrpc::response::GetBlockTrees>`
|
179 ~ impl From<GetBlockTrees> for zebra_rpc::methods::GetBlockTrees {
180 ~ fn from(val: GetBlockTrees) -> Self {
181 ~ zebra_rpc::methods::GetBlockTrees::new(val.sapling(), val.orchard())
|
|
useless conversion to the same type: `chain::error::BlockCacheError`:
zaino-fetch/src/chain/block.rs#L478
error: useless conversion to the same type: `chain::error::BlockCacheError`
--> zaino-fetch/src/chain/block.rs:478:23
|
478 | Err(e) => Err(e.into()),
| ^^^^^^^^ help: consider removing `.into()`: `e`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
|
`to_string` applied to a type that implements `Display` in `format!` args:
zaino-fetch/src/jsonrpc/error.rs#L39
error: `to_string` applied to a type that implements `Display` in `format!` args
--> zaino-fetch/src/jsonrpc/error.rs:39:80
|
39 | tonic::Status::internal(format!("Error: JsonRPC Client Error: {}", self.to_string()))
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `-D clippy::to-string-in-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::to_string_in_format_args)]`
|
useless conversion to the same type: `chain::error::BlockCacheError`:
zaino-fetch/src/chain/block.rs#L478
error: useless conversion to the same type: `chain::error::BlockCacheError`
--> zaino-fetch/src/chain/block.rs:478:23
|
478 | Err(e) => Err(e.into()),
| ^^^^^^^^ help: consider removing `.into()`: `e`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (beta)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Clippy (MSRV)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (MSRV)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Clippy (MSRV)
It seems that this Action is executed from the forked repository.
|
Clippy (MSRV)
GitHub Actions are not allowed to create Check annotations, when executed for a forked repos. See https://github.com/actions-rs/clippy-check/issues/2 for details.
|