Merge pull request #36 from idky137/bump_safely #89
ci.yml
on: push
Bitrot check
5m 25s
Clippy (MSRV)
4m 0s
Clippy (beta)
14s
Code coverage
15m 16s
Intra-doc links
6m 50s
Rustfmt
11s
Matrix: build-latest
Matrix: test
Annotations
22 errors and 4 warnings
Rustfmt
Process completed with exit code 1.
|
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
Latest build on ubuntu-latest
Process completed with exit code 101.
|
Latest build on macOS-latest
The job was canceled because "ubuntu-latest" failed.
|
Latest build on macOS-latest
Process completed with exit code 101.
|
Latest build on windows-latest
The job was canceled because "ubuntu-latest" failed.
|
Latest build on windows-latest
The operation was canceled.
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L445
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:445:25
|
445 | / return Err(Status::invalid_argument(format!(
446 | | "Failed to parse nym address: {}",
447 | | e
448 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
445 ~ Err(Status::invalid_argument(format!(
446 + "Failed to parse nym address: {}",
447 + e
448 ~ )))
|
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L257
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:257:25
|
257 | / return Err(Status::invalid_argument(format!(
258 | | "Failed to parse nym address: {}",
259 | | e
260 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
257 ~ Err(Status::invalid_argument(format!(
258 + "Failed to parse nym address: {}",
259 + e
260 ~ )))
|
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L445
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:445:25
|
445 | / return Err(Status::invalid_argument(format!(
446 | | "Failed to parse nym address: {}",
447 | | e
448 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
445 ~ Err(Status::invalid_argument(format!(
446 + "Failed to parse nym address: {}",
447 + e
448 ~ )))
|
|
unneeded `return` statement:
zingo-rpc/src/walletrpc/service.rs#L257
error: unneeded `return` statement
--> zingo-rpc/src/walletrpc/service.rs:257:25
|
257 | / return Err(Status::invalid_argument(format!(
258 | | "Failed to parse nym address: {}",
259 | | e
260 | | )));
| |___________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
257 ~ Err(Status::invalid_argument(format!(
258 + "Failed to parse nym address: {}",
259 + e
260 ~ )))
|
|
redundant closure:
zingo-rpc/src/primitives/block.rs#L70
error: redundant closure
--> zingo-rpc/src/primitives/block.rs:70:30
|
70 | hex::decode(hex).map(|bytes| SerializedBlock::from(bytes))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `SerializedBlock::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
|
needlessly taken reference of both operands:
zingo-rpc/src/nym/utils.rs#L25
error: needlessly taken reference of both operands
--> zingo-rpc/src/nym/utils.rs:25:8
|
25 | if &body_len != &data[cursor.position() as usize..].len() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `-D clippy::op-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::op_ref)]`
help: use the values directly
|
25 | if body_len != data[cursor.position() as usize..].len() {
| ~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
redundant closure:
zingo-rpc/src/primitives/block.rs#L70
error: redundant closure
--> zingo-rpc/src/primitives/block.rs:70:30
|
70 | hex::decode(hex).map(|bytes| SerializedBlock::from(bytes))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `SerializedBlock::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `-D clippy::redundant-closure` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
|
needlessly taken reference of both operands:
zingo-rpc/src/nym/utils.rs#L25
error: needlessly taken reference of both operands
--> zingo-rpc/src/nym/utils.rs:25:8
|
25 | if &body_len != &data[cursor.position() as usize..].len() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `-D clippy::op-ref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::op_ref)]`
help: use the values directly
|
25 | if body_len != data[cursor.position() as usize..].len() {
| ~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Clippy (MSRV)
Clippy had exited with the 101 exit code
|
Test on ubuntu-latest
Process completed with exit code 101.
|
Test on windows-latest
The job was canceled because "ubuntu-latest" failed.
|
Test on windows-latest
The operation was canceled.
|
Test on macOS-latest
The job was canceled because "ubuntu-latest" failed.
|
Test on macOS-latest
Process completed with exit code 101.
|
Code coverage
Process completed with exit code 1.
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (beta)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Clippy (MSRV)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (MSRV)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|