ZIP Changes - Draft PR #983
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| public class MatchTypes { |
Check warning
Code scanning / PMD
This utility class has a non-private constructor Warning
|
|
||
| public static Map<String, IMatchType> allMatchTypes;// = new HashMap<String, IMatchType>(); | ||
|
|
||
| protected MatchTypes(){ |
Check warning
Code scanning / PMD
Document empty constructor Warning
| if (allMatchTypes == null) { | ||
| allMatchTypes = new HashMap<String, IMatchType>(); | ||
| } |
Check warning
Code scanning / PMD
Singleton is not thread safe Warning
| } | ||
|
|
||
| public static String[] getAllMatchTypes() { | ||
| IMatchType[] zo = allMatchTypes.values().toArray(new IMatchType[allMatchTypes.size()]); |
Check warning
Code scanning / PMD
This call to Collection.toArray() may be optimizable Warning
| @@ -122,7 +122,7 @@ | |||
|
|
|||
| @JsonIgnore | |||
| public boolean isDontUse() { | |||
| return (matchType != null && matchType.contains(MatchType.DONT_USE)); | |||
| return (matchType != null && matchType.contains(MatchTypes.DONT_USE)); | |||
Check warning
Code scanning / PMD
Useless parentheses. Warning
| @@ -23,8 +24,8 @@ | |||
|
|
|||
| //add first stopWordRemover | |||
| List<FieldDefinition> fdList = new ArrayList<FieldDefinition>(4); | |||
| ArrayList<MatchType> matchTypelistFuzzy = new ArrayList<MatchType>(); | |||
| matchTypelistFuzzy.add(MatchType.FUZZY); | |||
| ArrayList<IMatchType> matchTypelistFuzzy = new ArrayList<IMatchType>(); | |||
Check warning
Code scanning / PMD
Avoid using implementation types like 'HashMap'; use the interface instead Warning test
FabricNotebook
Documentation changes
| * product descriptions | ||
| */ | ||
| TEXT("TEXT"), | ||
| public MatchType(){ |
Check warning
Code scanning / PMD
Document empty constructor Warning
common/core/src/main/java/zingg/common/core/preprocess/INeedsPreprocMap.java
Fixed
Show fixed
Hide fixed
common/core/src/main/java/zingg/common/core/preprocess/IPreprocOrder.java
Fixed
Show fixed
Hide fixed
|
|
||
| public interface IPreprocTypes { | ||
|
|
||
| public final static IPreprocType STOPWORDS = new PreprocType("stopwords"); |
Check warning
Code scanning / PMD
Unnecessary modifier 'private' on constructor 'LabelMatchType(Double, String)': enum constructors are implicitly private Warning
common/core/src/main/java/zingg/common/core/preprocess/IPreprocessor.java
Fixed
Show fixed
Hide fixed
common/core/src/main/java/zingg/common/core/preprocess/IPreprocessor.java
Fixed
Show fixed
Hide fixed
common/core/src/main/java/zingg/common/core/preprocess/IPreprocessors.java
Fixed
Show fixed
Hide fixed
common/core/src/main/java/zingg/common/core/preprocess/IPreprocessors.java
Fixed
Show fixed
Hide fixed
|
|
||
| String name; | ||
|
|
||
| public PreprocType(){ |
Check warning
Code scanning / PMD
Document empty constructor Warning
There was a problem hiding this comment.
PMD found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
* blocking tree changes * moved the set logic to block * reverted back tests * reverted back test data * removed unused code * added back commented code * ftd changes * refactor * simplified if-else * removed unused imports * ftd changes * changed absolute path * refactored class naming * config changes * changed tot this()
* blocking tree changes * moved the set logic to block * reverted back tests * reverted back test data * removed unused code * added back commented code * ftd changes * refactor * simplified if-else * removed unused imports * ftd changes * changed absolute path * refactored class naming * config changes * changed tot this() * changes directory structure
No description provided.