Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std.zig.system: Move CPU feature hacks after ABI detection. #22526

Merged
merged 2 commits into from
Jan 18, 2025
Merged

std.zig.system: Move CPU feature hacks after ABI detection. #22526

merged 2 commits into from
Jan 18, 2025

Conversation

alexrp
Copy link
Member

@alexrp alexrp commented Jan 18, 2025 •
edited
Loading

This was accidentally broken in #22434. See #22513 (comment) for an explanation.

cc @andrewrk @Rexicon226

@alexrp alexrp mentioned this pull request Jan 18, 2025
Merged
Rexicon226
Rexicon226 reviewed Jan 18, 2025
View reviewed changes
Copy link
Contributor

@Rexicon226 Rexicon226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, my bad! I should have noticed that those hacks are modifying cpu and not the query.

@alexrp alexrp force-pushed the cpu-feature-hacks branch from 62b79a9 to 515c970 Compare January 18, 2025 12:00
@andrewrk
Copy link
Member

Nice, thanks!

@andrewrk andrewrk merged commit a5d2aaa into ziglang:master Jan 18, 2025
10 checks passed
@alexrp alexrp deleted the cpu-feature-hacks branch January 19, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rexicon226 Rexicon226 Rexicon226 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrp @andrewrk @Rexicon226