Support building glibc for riscv32/riscv64 #20909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vast majority of Linux systems will be running these ABIs.
This target triple was weird on multiple levels: * The `ilp32` ABI is the soft float ABI. This is not the main ABI we want to support on RISC-V; rather, we want `ilp32d`. * `gnuilp32` is a bespoke tag that was introduced in Zig. The rest of the world just uses `gnu` for RISC-V target triples. * `gnu_ilp32` is already the name of an ILP32 ABI used on AArch64. `gnuilp32` is too easy to confuse with this. * We don't use this convention for `riscv64-linux-gnu`. * Supporting all RISC-V ABIs with this convention will result in combinatorial explosion; see ziglang#20690.
The former are soft float; the latter are hard float. We primarily care about hard float here. Signed-off-by: Alex Rønne Petersen <[email protected]>
~Same thing as b03a04c.
The former are soft float; the latter are hard float. We primarily care about hard float here.
This was referenced Aug 7, 2024
This was referenced Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO_INITFINI, though. I also am not including the.cfi_labelworkaround because we're expecting to upgrade to LLVM 19 in this release cycle, which contains [MC] Support .cfi_label llvm/llvm-project#97922.riscv32-linux-gnuilp32target triple toriscv32-linux-gnu. This is consistent withriscv64-linux-gnu. The old triple was weird for multiple reasons; see the commit message.ilp32/lp64references withilp32d/lp64das the hard float ABIs are expected to be the most common on Linux systems by far. The other ABIs can come later (ideally after RFC/Proposal: Turning Zig target triples into quadruples #20690, or something like it).Closes #3340.
Closes #19107.