Fixed matplotlib fatbands and enabled opacity #862
Conversation
|
Here with "area_line", where previously the red area would have hidden the blue one in the valence bands. Now it is clear that both contribute:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
==========================================
- Coverage 86.98% 86.98% -0.01%
==========================================
Files 403 403
Lines 52552 52559 +7
==========================================
+ Hits 45712 45717 +5
- Misses 6840 6842 +2 ☔ View full report in Codecov by Sentry. |
| @@ -380,6 +381,8 @@ def draw_multisize_line( | |||
| # Set the values used for colormapping | |||
| lc.set_linewidth(line.get("width", 1)) | |||
| lc.set_linestyle(self._plotly_dash_to_matplotlib(line.get("dash", "solid"))) | |||
| lc.set_color(line.get("color")) | |||
| lc.set_alpha(line.get("opacity")) | |||
There was a problem hiding this comment.
a bit pedantic here, but matplotlib users are used to using alpha=, could it allow both things?
There was a problem hiding this comment.
I think it would become a complete chaos if I try to support all keywords of all backends 😅
I took the decision to stick to plotly terminology in general to make things easier to maintain and document.
| @@ -380,6 +381,8 @@ def draw_multisize_line( | |||
| # Set the values used for colormapping | |||
| lc.set_linewidth(line.get("width", 1)) | |||
| lc.set_linestyle(self._plotly_dash_to_matplotlib(line.get("dash", "solid"))) | |||
| lc.set_color(line.get("color")) | |||
| lc.set_alpha(line.get("opacity")) | |||
#790 had not been fully fixed by #799. There were some bugs regarding
fatbands_mode="scatter"andfatbands_mode="line"for the matplotlib backend.Also enabled the possibility to use
"opacity"for all variants of fatbands, to avoid some fatbands getting hidden by the overlap with the next ones.With the example that @rreho provided using "scatter" "and matplotlib", and setting
"opacity": 0.2for the red fatbands: