Support for conditional expressions on workflows. #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things like "a = function_1() if test() else function_2()" are now valid as workflow code. This removes the need for having to call/define a function that just does the branching. Furthermore, since the conditional expression is now understood and parsed into a custom "ConditionalExpressionSyntaxNode", only the branch needed (as decided by `test()`) is executed. Comparison syntax (e.g. "a == b") is also parsed into a custom node, therefore it is now allowed in the syntax of workflows.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self._outdate_due_to_inputs = False | ||
| raise | ||
|
|
||
| def _receive_outdated(self): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
==========================================
- Coverage 87.62% 87.61% -0.02%
==========================================
Files 364 364
Lines 48865 48944 +79
==========================================
+ Hits 42819 42880 +61
- Misses 6046 6064 +18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR one can use conditional expressions and comparisons inside the workflow code, which will be parsed to
ConditionalExpressionSyntaxNodeandCompareSyntaxNoderespectively.This removes the need for having to use/define a function just to write an if/else expression, so it makes workflows simpler to explain.
Also, by parsing the conditional expressions into a node, we can safely compute only the branch of the conditional that is needed, which is nice.
I have rewritten some plots to use this.
As an example, now this is valid:
and the diagram of the workflow created looks like this: