removed BaseException and made BTD coherent

Signed-off-by: Nick Papior <[email protected]>

src/sisl/io/siesta/binaries.py

@@ -1646,7 +1646,7 @@ def func(atom_):
                     n[io, i_s] = orb.n
                     l[io, i_s] = orb.l
                     zeta[io, i_s] = orb.zeta
-        except:
+        except Exception:
             pass  # should we warn?
 
         args.extend([n, l, zeta])

src/sisl/io/siesta/stdout.py

@@ -119,7 +119,7 @@ def _parse_version(attr, instance, match):
     version, *spec = opt.split("-", maxsplit=1)
     try:
         version = tuple(int(v) for v in version.split("."))
-    except BaseException:
+    except Exception:
         version = (0, 0, 0)
 
     # Convert version to a tuple
@@ -1431,7 +1431,7 @@ def try_parse_int(s):
                             "Mulliken Atomic Populations",
                             "Mulliken Net Atomic Populations",
                         ]
-                except BaseException:
+                except Exception:
                     pass
 
         else:

src/sisl_toolbox/btd/_btd.py

@@ -615,7 +615,14 @@ def from_fdf(cls, fdf, prefix="TBT", use_tbt_se=False, eta=None):
         is_tbtrans = prefix.upper() == "TBT"
 
         # Read the device H, only valid for TBT stuff
-        Hdev = si.get_sile(fdf.get("TBT.HS", f"{slabel}.TSHS")).read_hamiltonian()
+        for hs_ext in ("TS.HSX", "TSHS", "HSX"):
+            if Path(f"{slabel}.{hs_ext}").exists():
+                # choose a sane default (if it exists!)
+                hs_default = f"{slabel}.{hs_ext}"
+                break
+        else:
+            hs_default = f"{slabel}.TSHS"
+        Hdev = si.get_sile(fdf.get("TBT.HS", hs_default)).read_hamiltonian()
 
         def get_line(line):
             """Parse lines in the %block constructs of fdf's"""

tools/changelog.py

@@ -123,7 +123,7 @@ def get_pull_requests(repo, revision_range):
 
         try:
             prs.append(repo.get_pull(n))
-        except BaseException:
+        except Exception:
             pass
 
     return prs