New Greeter demo for C# #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Jan 27, 2025
| @@ -0,0 +1,17 @@ | |||
| // Copyright (c) ZeroC, Inc. | |||
|
|
|||
| // Extends Program to provide the CancelKeyPressed property. | |||
There was a problem hiding this comment.
In icerpc-csharp, this file is in a common folder.
| internal class Chatbot : GreeterDisp_ | ||
| { | ||
| // Implements the abstract method greet from the GreeterDisp_ class generated by the Slice compiler. | ||
| public override string greet(string name, Ice.Current current) |
There was a problem hiding this comment.
This is a "sync" dispatch, which is the simplest, and certainly ok when the dispatch is indeed sync.
Should I add a GreeterAsync demo that shows AMD, similar to the C++ greeterAsync demo?
|
|
||
| // Send a request to the remote object and get the response. | ||
| // TODO: remap to GreetAsync with cs:identifier | ||
| string greeting = await greeter.greetAsync(Environment.UserName); |
There was a problem hiding this comment.
I think we should only demo the client-side async API. The sync API is for backwards compatibility - you probably shouldn't use it in new applications.
| You can build the client and server applications with: | ||
|
|
||
| ``` shell | ||
| dotnet build |
There was a problem hiding this comment.
I was building with:
dotnet build /p:IceHome=$HOME/builds/ice /p:IceToolsPath=$HOME/builds/ice/cpp/bin
externl
approved these changes
Jan 28, 2025
| internal class Chatbot : GreeterDisp_ | ||
| { | ||
| // Implements the abstract method greet from the GreeterDisp_ class generated by the Slice compiler. | ||
| public override string greet(string name, Ice.Current current) |
pepone
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new greeter demo is a port of the IceRPC slice/Greeter example. In particular, it uses a similar layout and build system.