utils: string: fix the global-buffer-overflow from AddressSanitizer #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the FreeBSD implementation to fix the global-buffer-overflow triggered from strlen(src) in strlcpy(). Signed-off-by: Lang Xie <[email protected]>
|
@arnopo can you review this change since you are the author? |
|
@laxiLang , this repo is just a mirror. You should point your fix to https://github.com/OpenAMP/open-amp |
arnopo
reviewed
Oct 8, 2024
| @@ -49,5 +50,5 @@ strlcpy(char *dst, const char *src, size_t size) | |||
| if (nleft == 0 && size != 0) | |||
| *dst = '\0'; /* NUL-terminate dst */ | |||
|
|
|||
| return strlen(src); | |||
| return (s - src - 1); | |||
There was a problem hiding this comment.
The function has to return the total length of the string it tried to create so the size of the source (https://man.freebsd.org/cgi/man.cgi?strlcpy(3))
The freebsd add in code while (*src++) resulting in same overflow issue than strlen, but perhaps not...
if you detect a potential issue, please, comment OpenAMP/open-amp#620 with your observation that I fix it in the openamp repo
|
Fixed by PR #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the FreeBSD implementation to fix the global-buffer-overflow triggered from strlen(src) in strlcpy().