Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: modified rat token URL parameter #680

Merged
merged 1 commit into from
Feb 5, 2024
Merged

config: modified rat token URL parameter #680

merged 1 commit into from
Feb 5, 2024

Conversation

alejandromumo
Copy link
Member

@alejandromumo alejandromumo commented Dec 18, 2023 •
edited
Loading

Issue:

  • The argument name token collides with the secret links one
  • There is a a check on the argument name that prevents the RATNeed to be added to the identity if the argument names collide.

RAT tokens were broken in production due to this.

The new name resource-token was tested in zenodo-dev and deployed to prod, @lnielsen is aligned on this one.

I deployed the change to zenodo-dev and prod

@alejandromumo alejandromumo changed the title config: modified rat token arg name. config: modified RAT arg name. Dec 18, 2023
@alejandromumo alejandromumo changed the title config: modified RAT arg name. config: modified rat token URL parameter Dec 18, 2023
@slint slint merged commit f6e6d42 into zenodo:master Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrcastro2 jrcastro2 jrcastro2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alejandromumo @jrcastro2 @slint