wip: pgbouncer #615
Merged
wip: pgbouncer #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
commented
Oct 20, 2023
docker/pgbouncer/pgbouncer.ini
Outdated
| ;; session - after client disconnects (default) | ||
| ;; transaction - after transaction finishes | ||
| ;; statement - after statement finishes | ||
| pool_mode = session |
There was a problem hiding this comment.
This parameter must be checked very carefully
ntarocco
force-pushed
the
pgbouncer
branch
2 times, most recently
from
c1e1e73 to
2b7bc4a
Compare
ntarocco
commented
Oct 31, 2023
| @@ -68,8 +69,19 @@ APP_RDM_ROUTES["index"] = ("/", frontpage_view_function) | |||
| # Flask-SQLAlchemy | |||
| # ================ | |||
| # See https://flask-sqlalchemy.palletsprojects.com/en/2.x/config/ | |||
|
|
|||
| SQLALCHEMY_DATABASE_URI="postgresql+psycopg2://zenodo:zenodo@localhost/zenodo" | |||
| def _parse_env_bool(var_name, default=None): | |||
There was a problem hiding this comment.
can be removed when pgbouncer will be enabled by default
slint
approved these changes
Oct 31, 2023
ntarocco
commented
Oct 31, 2023
| ;; session - after client disconnects (default) | ||
| ;; transaction - after transaction finishes | ||
| ;; statement - after statement finishes | ||
| pool_mode = transaction |
There was a problem hiding this comment.
Pooler/connections settings must be reviewed carefully
There was a problem hiding this comment.
Based on the article above it looks ok. I don't think we ever rely on sequence values across transactions (e.g. for the recid sequence of the requests number, and hopefully SQLAlchemy doesn't do any fancy tricks under the hood either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice article to read: https://www.depesz.com/2012/12/02/what-is-the-point-of-bouncing/