Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ragas integration #194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: ragas integration #194

wants to merge 1 commit into from

Conversation

cabreraalex
Copy link
Member

Description

Ragas integration

@cabreraalex cabreraalex requested a review from neubig as a code owner December 5, 2023 23:10
@cabreraalex cabreraalex changed the title feat: ragas integratino feat: ragas integration Dec 5, 2023
neubig
neubig requested changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but could you please add a few select markdown cells so the demo is self-contained? I also think that it's probably more important to have the description in the beginning of the notebook rather than in a separate README so that we can link directly to the notebook.

@Sparkier
Copy link
Member

Sparkier commented Dec 6, 2023

This looks great, but could you please add a few select markdown cells so the demo is self-contained? I also think that it's probably more important to have the description in the beginning of the notebook rather than in a separate README so that we can link directly to the notebook.

If we're mostly moving to notebooks, do we even need all these READMEs anymore? Feel like there is some duplication of information which might lead to increased maintenance.

@neubig
Copy link
Collaborator

neubig commented Dec 6, 2023

Yes, I agree we probably don't need READMEs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neubig neubig neubig requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cabreraalex @Sparkier @neubig