This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
User language preference and user language menu #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovillegaszen
changed the title
added 6 commits
April 7, 2021 15:10
…e and added query type for languages
ovillegaszen
force-pushed
the
ovillegas/save-language
branch
from
83d61a4 to
f0b1eab
Compare
samzx
reviewed
Apr 7, 2021
|
todo: investigate why minitest is failing despite no failing tests |
added 2 commits
May 19, 2021 15:34
This reverts commit b5c8837.
ThuTrinh
reviewed
May 19, 2021
kerrisim
reviewed
Jun 30, 2021
app/javascript/pages/App/index.js
Outdated
| @@ -12,12 +12,23 @@ import { togglePopover } from 'actions' | |||
|
|
|||
| import AppQuery from './query.gql' | |||
|
|
|||
| // TODO refactor it into AppPage as a functional component | |||
| const MomentLocale = ({ children }) => { | |||
| // TODO refactor it into AppPage as a functional component // todo: change name | |||
There was a problem hiding this comment.
Is the name change todo completed?
kerrisim
reviewed
Jun 30, 2021
app/javascript/pages/App/index.js
Outdated
| const chosenLanguage = R.find(R.propEq('id', languageId))(languages) | ||
| const languageCode = R.prop('languageCode', chosenLanguage) | ||
| i18n.changeLanguage(languageCode, () => { | ||
| // TODO: Handle callback (error/success) |
There was a problem hiding this comment.
Is this going to be done in a separate issue?
kerrisim
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Description
Everything related to User Language Preference.
Menu Selection
Feed the language list to the language menu list
Write User Language Preference to the user preference table
Read the User Language preference on opening
References
[Github Issue] #493
Risks (if any)