Make app notifications appear in new workspaces + dismiss on all workspaces

[mgsloan]

The keymap error notifications got convoluted to support displaying the notification on startup. This change addresses it systemically for all future app notifications.

Reverts most of #20531, while keeping the fix to handle keyboard layout switching. This is a better fix for #20531

Release Notes:

• N/A

[notpeter]

Would this also fix:

• Open the Release Notes toast in the foreground window after an update is installed #23236

Because the update toast would appear in all workspaces simultaneously (not just the one)?

[contrast-jproberts]

Would this also fix:

• Open the Release Notes toast in the foreground window after an update is installed #23236

Because the update toast would appear in all workspaces simultaneously (not just the one)?

Heh, I was about to open a PR for this using the older behavior. The new show_app_notification sounds great and I think it would resolve #23236 ! However, I'm not sure that it's working as described. It's totally possible that my testing method is flawed though. Here's what I tried:

• Pull this branch
• Apply this patch (with newline before EOF, that's usually truncated by GitHub)

diff --git a/crates/auto_update_ui/src/auto_update_ui.rs b/crates/auto_update_ui/src/auto_update_ui.rs
index 9114375e88..8c75ce838f 100644
--- a/crates/auto_update_ui/src/auto_update_ui.rs
+++ b/crates/auto_update_ui/src/auto_update_ui.rs
@@ -124,7 +124,7 @@ pub fn notify_of_any_new_update(cx: &mut ViewContext<Workspace>) -> Option<()> {
 
     cx.spawn(|workspace, mut cx| async move {
         let should_show_notification = should_show_notification.await?;
-        if should_show_notification {
+        if true {
             workspace.update(&mut cx, |workspace, cx| {
                 let workspace_handle = workspace.weak_handle();
                 workspace.show_notification(

• Build and run Zed
• Open 2 workspaces
• I see notifications in both workspaces, which is great
• However, when I dismiss the notification in 1 workspace, it doesn't get dismissed in the other. I've tried this with both the first workspace and the second workspace in the window stack. Neither case dismissed the notification across workspaces.

Do you mind taking a look at this scenario before merging this work? For folks who are messy and have multiple workspaces (like me), it would be a little tedious to go through every workspace and dismiss the notification after auto-update. If the first dismissal propagates across all workspaces like you planned, that sounds perfect!