pane: Hide "Copy Relative Path" and "Reveal In Project Panel" actions for files outside of the projects #23349
+20
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Check for this action is already in place but it always passes because resolved relative path is an empty Path.
Poldraunic
force-pushed
the
pane-treat-empty-path-as-if-it-were-none
branch
from
16a4038 to
a6aeb3a
Compare
| @@ -2466,7 +2466,9 @@ impl Pane { | |||
| .read(cx) | |||
| .item_for_entry(entry, cx) | |||
| .and_then(|item| item.project_path(cx)) | |||
| .map(|project_path| project_path.path); | |||
| .map(|project_path| project_path.path) | |||
| .map_or(None, |path| if path.exists() { Some(path) } else { None }); | |||
There was a problem hiding this comment.
.exists()
-
We prefer to avoid using
std::fs-related methods and useFsinstead,in this case.Line 112 in 5e210c0
-
This is a rendering code, potentially called 120 times/second, calling whatever FS-related things here is madness.
Is there another way we can check that file is outside of projects? -
We can be on remote, where the client will have no FS at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #21000.
"Copy Relative Path" action had a check for existence of relative path but it always passed because
WorktreeStore::find_worktree()function returned empty path for these kinds of files. It feels correct to make changes there, but I don't know what else could be impacted."Reveal In Project Panel" had no check whatsoever and so I made one.
Release Notes: