-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pre-task dispatching #23258
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Carter Canedy.
|
d14355e
to
611a2bf
Compare
We require contributors to sign our Contributor License Agreement, and we don't have @cartercanedy on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
611a2bf
to
9651aec
Compare
e55343d
to
a3def29
Compare
@osiewicz I'm still not done, but do you agree with the direction I'm going? |
7ae7d30
to
e473eac
Compare
Hey @cartercanedy, |
f464174
to
e473eac
Compare
The semantics of the changes are ready to get reviewed. I'll work on tests, clippy lints, fmt, etc. in the meantime |
32634c9
to
08b4596
Compare
I'm removing post-task dispatching from the scope of this PR to make the changes more manageable to review |
2107687
to
b8ac078
Compare
Implement dependency dispatching
Tasks can specify other tasks by label to execute before being executed, with each task waiting on a zero exit code before beginning or cancelling the remaining queued tasks on a non-zero exit code.
I couldn't find any issues that referenced this easily, but @osiewicz and I were discussing this in the context of pre-debug tasks,
but this feature should be generally available to all task types
Release Notes: