Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pre-task dispatching #23258

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

cartercanedy
Copy link

@cartercanedy cartercanedy commented Jan 16, 2025

Implement dependency dispatching

Tasks can specify other tasks by label to execute before being executed, with each task waiting on a zero exit code before beginning or cancelling the remaining queued tasks on a non-zero exit code.

I couldn't find any issues that referenced this easily, but @osiewicz and I were discussing this in the context of pre-debug tasks,
but this feature should be generally available to all task types

Release Notes:

  • Added pre-task task execution

Copy link

cla-bot bot commented Jan 16, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Carter Canedy.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Jan 16, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @cartercanedy on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cartercanedy
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 16, 2025
Copy link

cla-bot bot commented Jan 16, 2025

The cla-bot has been summoned, and re-checked this pull request!

@osiewicz osiewicz self-requested a review January 16, 2025 21:18
@maxdeviant maxdeviant changed the title feat: implement pre-/post-task task dispatching Implement pre/post-task task dispatching Jan 16, 2025
@osiewicz osiewicz self-assigned this Jan 16, 2025
crates/project/src/task_inventory.rs Outdated Show resolved Hide resolved
crates/project/src/graph.rs Outdated Show resolved Hide resolved
@zed-industries-bot
Copy link

zed-industries-bot commented Jan 17, 2025

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- Added/Fixed/Improved ...

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against 80fdf61

@cartercanedy cartercanedy force-pushed the task-queue branch 4 times, most recently from e55343d to a3def29 Compare January 17, 2025 21:47
@cartercanedy
Copy link
Author

cartercanedy commented Jan 19, 2025

@osiewicz I'm still not done, but do you agree with the direction I'm going?

@cartercanedy cartercanedy force-pushed the task-queue branch 2 times, most recently from 7ae7d30 to e473eac Compare January 20, 2025 19:07
@osiewicz
Copy link
Contributor

Hey @cartercanedy,
I'll take a review pass over your PR on Thursday. I hope that's ok

@cartercanedy cartercanedy marked this pull request as ready for review January 21, 2025 17:40
@cartercanedy
Copy link
Author

The semantics of the changes are ready to get reviewed. I'll work on tests, clippy lints, fmt, etc. in the meantime

@cartercanedy cartercanedy changed the title Implement pre/post-task task dispatching Implement pre-task dispatching Jan 21, 2025
@cartercanedy
Copy link
Author

I'm removing post-task dispatching from the scope of this PR to make the changes more manageable to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants