Initial breaking changes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This ensures we don't collide with `schemer` going forward.
str4d
force-pushed
the
initial-breaking-changes
branch
from
2326fdf to
a2552d0
Compare
str4d
commented
Oct 15, 2024
| - **IMPORTANT BREAKING CHANGE**: `schemerz_postgres::PostgresAdapter::new` now | ||
| uses a default table name of `_schemerz` when the `table_name` argument is | ||
| `None`. If you were not setting this argument before and are migrating from | ||
| `schemer`, you will need to set `table_name` to `Some("_schemer".into())`. |
There was a problem hiding this comment.
We were the only public dependent on schemer, so I think this notice should be all we need to do. But an alternative would be to remove the default and require the caller to always specify the table name.
nuttycom
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are necessary changes vs
schemerthat I didn't do in #1 to keepschemerz 0.1.0intentionally compatible with the latest version ofschemer, but that need to be done going forward.