[do not merge] sketch of a refactor for core modules #2780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while working on #2665, I had the following experience in the
group.py
module:We already have something like this in our
api
module, which is split intoasynchronous
andsynchronous
modules, where the latter imports from the former. I am proposing to use the same logical arrangement inside thegroup
andarray
modules.This PR is a rough outline of what that would look like. tests will not pass. My request is that you look at how the code in the new
group
module is arranged, and weigh in on whether you think this direction makes sense.