Update set_partial_values to accept Buffer rather than BytesLike #2688
+28
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #2614 in https://github.com/maxrjones/zarr-python/tree/testing-storage, I found that the current implementation of
set_partial_values
for local store cannot work as written because it passesBytesLike
to_put
which expects a buffer. None of the other stores implementset_partial_values
, so it's not possible to look to them for the correct way of implementing this method.I believe that one of the following needs to happen in order for stores to correctly implement
set_partial_values
:prototype
argument toset_partial_values
that can be used to go from BytesLike -> Bufferset_partial_values
to acceptBuffer
types rather thanBytesLike
typesI chose the second option for this PR because all the other
set
methods seem to acceptBuffer
types. Of course, I welcome corrections if I am not understanding something here and the function signature should work as-is.