Critical operation PDB #2830
Merged
Critical operation PDB #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughcapet
added
enhancement
architectural
hughcapet
force-pushed
the
feature/critical-operations-pdb
branch
from
892fda8 to
ac0634d
Compare
idanovinda
reviewed
Jan 6, 2025
hughcapet
requested review from
sdudoladov,
Jan-M,
FxKu,
jopadi and
macedigital
as code owners
FxKu
reviewed
Jan 27, 2025
| Statefulset *appsv1.StatefulSet | ||
| VolumeClaims map[types.UID]*v1.PersistentVolumeClaim | ||
| GeneralPodDisruptionBudget *policyv1.PodDisruptionBudget | ||
| CriticalOpPodDisruptionBudget *policyv1.PodDisruptionBudget |
There was a problem hiding this comment.
ok probably it would require quite a few more code changes then ... we can also leave it as is
FxKu
reviewed
Jan 27, 2025
FxKu
reviewed
Jan 27, 2025
|
Documentation is still missing. |
FxKu
reviewed
Jan 27, 2025
FxKu
reviewed
Jan 27, 2025
FxKu
reviewed
Jan 27, 2025
FxKu
reviewed
Jan 27, 2025
FxKu
reviewed
Jan 27, 2025
| c.CriticalOpPodDisruptionBudget = newPdb | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
with a map we would not need so much redundant code
FxKu
reviewed
Jan 27, 2025
FxKu
reviewed
Jan 27, 2025
FxKu
reviewed
Jan 27, 2025
hughcapet
force-pushed
the
feature/critical-operations-pdb
branch
from
dddcd56 to
a877524
Compare
FxKu
reviewed
Jan 28, 2025
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the second PDB to cover Pods with a special "critical operation" label set.
This label is going to be assigned to all pg cluster's Pods by the Operator during a PG major version upgrade, by Patroni during a cluster/replica bootstrap. It can also be set manually or by any other automation tool.