Skip to content

Commit

Permalink
Typos and minor fixes (kserve#3429)
Browse files Browse the repository at this point in the history
Signed-off-by: Alex Peters <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
  • Loading branch information
alpe and yuzisun authored Jun 2, 2024
1 parent d393486 commit 4b58775
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions pkg/controller/v1beta1/inferenceservice/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ import (
// +kubebuilder:rbac:groups=core,resources=events,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=core,resources=pods,verbs=get;list;watch

// InferenceState describes the Readiness of the InferenceService
// InferenceServiceState describes the Readiness of the InferenceService
type InferenceServiceState string

// Different InferenceServiceState an InferenceService may have.
Expand All @@ -96,8 +96,6 @@ type InferenceServiceReconciler struct {
}

func (r *InferenceServiceReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
_ = context.Background()

// Fetch the InferenceService instance
isvc := &v1beta1api.InferenceService{}
if err := r.Get(ctx, req.NamespacedName, isvc); err != nil {
Expand Down Expand Up @@ -261,7 +259,7 @@ func (r *InferenceServiceReconciler) Reconcile(ctx context.Context, req ctrl.Req
}

if err = r.updateStatus(isvc, deploymentMode); err != nil {
r.Recorder.Eventf(isvc, v1.EventTypeWarning, "InternalError", err.Error())
r.Recorder.Event(isvc, v1.EventTypeWarning, "InternalError", err.Error())
return reconcile.Result{}, err
}

Expand Down

0 comments on commit 4b58775

Please sign in to comment.