Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI 修復 #90

Merged
merged 3 commits into from
Jan 8, 2025
Merged

CI 修復 #90

merged 3 commits into from
Jan 8, 2025

Conversation

ykws
Copy link
Member

@ykws ykws commented Dec 26, 2024

現状の CI 修復が難しそうなので CI がパスしている以下のコミットの時点まで一度元に戻します

GitHub Action の性質上、この PR の CI は変更前の状態で動くためパスしないです。

以下 PR で、Example プロジェクトのビルドとテストを導入してもらいましたが、 Example にはテストがビルドエラーになるバグを意図して混入させているため、 CI を導入しにくいです。ビルドだけならできなくはないはずですが、ビルドが壊れているのを課題とする判断もありかもしれません。

動作確認

該当マージコミットの PR branch を restore して Action を実行してパスすることを確認しました

https://github.com/yumemi-inc/ios-training/actions/runs/12504707219

同様に下記マージコミットの PR branch を restore して Action を実行すると失敗することを確認しました

https://github.com/yumemi-inc/ios-training/actions/runs/12495208606

@ykws ykws requested a review from a team December 26, 2024 14:18
@ykws ykws self-assigned this Dec 26, 2024
@ykws ykws added the bug Something isn't working label Dec 26, 2024
@ykws ykws linked an issue Dec 30, 2024 that may be closed by this pull request
Copy link
Contributor

@yumemi-kumagai yumemi-kumagai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良好 (lgtm)-badge

ありがとうございます!

@ykws ykws merged commit 0063e97 into main Jan 8, 2025
1 of 3 checks passed
@ykws ykws deleted the feature/fix-ci branch January 8, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Failed
2 participants