Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate class-attributes.md to Japanese #556

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

K-dash
Copy link
Contributor

@K-dash K-dash commented Jun 17, 2024

Related to #545

class-attributes.mdの日本語版Docを作成しました。

  • docs/en/class-attributes.md の修正点
    • Type Checkのドキュメントの参照がページ内リンクになっていたため修正
    • 脚注1をタイトル付きのリンクに変更し、該当URLに飛べるように修正

レビューをお願いします 🙏

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.04%. Comparing base (ac3c68f) to head (a6638dc).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files          13       13           
  Lines        1942     1942           
  Branches      437      437           
=======================================
  Hits         1768     1768           
  Misses        117      117           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@K-dash
Copy link
Contributor Author

K-dash commented Jun 18, 2024

a6638dc

申し訳ありません。今更ながら (de)serializationの部分を、デシリアライズ と表記していることに気づきました…
これだと「デシリアライズ」に限定した表現になってしまい誤解を招く可能性があるため、英語版Docを踏襲する形で (デ)シリアライズ に表記を変更しました。

すでにマージしていただいた getting-started.mddecorators.md については別PRで修正予定です。

Copy link
Owner

@yukinarit yukinarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yukinarit yukinarit merged commit 0e9a773 into yukinarit:main Jun 18, 2024
8 checks passed
@K-dash K-dash deleted the translate-class-attributes-en-to-ja branch June 18, 2024 06:47
@yukinarit yukinarit added the documentation Improvements or additions to documentation label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants