Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support different controller families in strawberry configuration #355

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Support different controller families in strawberry configuration #355

merged 6 commits into from
Nov 11, 2024

Conversation

dmi-feo
Copy link
Collaborator

@dmi-feo dmi-feo commented Oct 9, 2024

l0kix2
l0kix2 reviewed Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@l0kix2 l0kix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I want someone else who knows a bit about strawberry look at this.
@psushin does this change helps for you with livy?

pkg/consts/defaults.go Show resolved Hide resolved
koct9i
koct9i reviewed Nov 4, 2024
View reviewed changes
api/v1/ytsaurus_types.go Outdated Show resolved Hide resolved
@l0kix2
Copy link
Collaborator

l0kix2 commented Nov 8, 2024

Let's add docstrings and merge it i guess?
@dmi-feo

@l0kix2 l0kix2 merged commit eae8949 into main Nov 11, 2024
5 checks passed
@l0kix2 l0kix2 deleted the straw-conf branch November 11, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koct9i koct9i koct9i left review comments

@l0kix2 l0kix2 l0kix2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
yt-k8s-operator project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmi-feo @l0kix2 @koct9i