Avoid dangerous try/except/pass pattern on Ravel connection

ysard · Nov 10, 2021 · 2a6d665 · 2a6d665
1 parent 8122ab2
commit 2a6d665
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/resources/lib/dbus_pulseaudio.py b/resources/lib/dbus_pulseaudio.py
@@ -1,6 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
 # Copyright (C) 2020-present Team LibreELEC
 
+import traceback
+import log
 import dbus_utils
 import dbussy
 import ravel
@@ -54,4 +56,5 @@ def call_method(bus_name, path, interface, method_name, *args, **kwargs):
     conn.bus_unique_name = 'PulseAudio'
     BUS = ravel.Connection(conn, False)
 except Exception as e:
-    pass
+    log.log('pulseaudio module; init fail: ' + str(e), log.ERROR)
+    log.log(traceback.format_exc(), log.ERROR)