add support state classes for parent element #187 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yowainwright
requested changes
Feb 26, 2021
There was a problem hiding this comment.
Thanks for your consideration @Ibrahimrahhal. 🙏
See my comment in the PR.
Also, there will need to be tests before I can approve.
Thanks!!! 🙂
| @@ -350,7 +356,8 @@ class Stickybits { | |||
| // Only apply new styles if the state has changed | |||
| if (state === it.state && stateChange === it.stateChange) return | |||
| rAF(() => { | |||
| const stateStyles = { | |||
| const stateStyles = { }; | |||
| stateStyles.element = { | |||
There was a problem hiding this comment.
This is a breaking change.
It looks like the updated parent class [stickyParent] could be added below line 361 within the classes object (also for adding the other parent css classes).
This change will simplify the rest of the PR.
There was a problem hiding this comment.
@yowainwright Agree! I'll do the change & resubmit a review. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding state classes support for parent elements