Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zipper): router can be customized in NewZipper() #667

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Nov 13, 2023

No description provided.

@woorui woorui requested a review from venjiang as a code owner November 13, 2023 06:28
Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
yomo ⬜️ Ignored (Inspect) Nov 13, 2023 6:28am

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #667 (07ec60f) into master (a0047c8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #667   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files          36       36           
  Lines        2672     2672           
=======================================
  Hits         1596     1596           
  Misses        981      981           
  Partials       95       95           
Files Coverage Δ
zipper.go 74.28% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@fanweixiao fanweixiao changed the title feat: inject router when new zipper feat(zipper): router can be customized in NewZipper() Nov 13, 2023
Copy link
Member

@fanweixiao fanweixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@woorui woorui merged commit 94370ab into master Nov 13, 2023
5 checks passed
@woorui woorui deleted the refactor/inject-router branch November 13, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants