feat: stream #649
Closed
feat: stream #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
wujunzhuo
reviewed
Oct 17, 2023
| if err != nil { | ||
| return err | ||
| } | ||
| defer sourceStream.Close() |
There was a problem hiding this comment.
seems that server should not close this stream
woorui
reviewed
Oct 21, 2023
| return | ||
| } | ||
| // connection | ||
| conn, err := s.NewConnection(qconn, fs, hf) |
There was a problem hiding this comment.
This error should be write back to client and let client know why it be closed.
| return | ||
| } | ||
| // route | ||
| route, err := s.handleRoute(hf, conn.Metadata()) |
There was a problem hiding this comment.
This error is same as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pipe stream