Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log): better log outputs when dispatching to downstreams #644

Merged
merged 7 commits into from
Oct 20, 2023

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Oct 11, 2023

No description provided.

@woorui woorui requested a review from fanweixiao October 11, 2023 11:17
@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
yomo ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 8:27am

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #644 (6b71002) into master (cf56978) will increase coverage by 0.19%.
The diff coverage is 76.84%.

@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
+ Coverage   60.08%   60.28%   +0.19%     
==========================================
  Files          36       36              
  Lines        2681     2702      +21     
==========================================
+ Hits         1611     1629      +18     
- Misses        968      970       +2     
- Partials      102      103       +1     
Files Coverage Δ
core/metadata.go 90.90% <ø> (-2.12%) ⬇️
core/server.go 66.00% <100.00%> (+0.34%) ⬆️
core/server_options.go 79.41% <ø> (ø)
source.go 80.48% <92.85%> (+1.82%) ⬆️
zipper.go 75.00% <88.23%> (+2.58%) ⬆️
core/client.go 67.66% <72.72%> (+1.47%) ⬆️
sfn.go 47.87% <55.17%> (+2.12%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fanweixiao fanweixiao changed the title feat: approve log & remove dead code feat(log): better log outputs when dispatching to downstreams Oct 14, 2023
Copy link
Member

@fanweixiao fanweixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

downstream_id seems is the zipper-self, not as expected.

zipper.go Outdated Show resolved Hide resolved
zipper.go Outdated Show resolved Hide resolved
zipper.go Outdated Show resolved Hide resolved
Copy link
Member

@fanweixiao fanweixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, perfect job @woorui 👍🏻

@fanweixiao fanweixiao merged commit 82e17ff into master Oct 20, 2023
5 checks passed
@fanweixiao fanweixiao deleted the feat/log branch October 20, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants