Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: version negotiation #639

Merged
merged 5 commits into from
Dec 15, 2023
Merged

feat: version negotiation #639

merged 5 commits into from
Dec 15, 2023

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Oct 9, 2023

Description

Adding version negotiation between zipper and source/sfn, if version negotiation failed, the source/sfn cannot connect to zipper.

The version format must follow the Major.Minor.Patch formatting, and the Major, Minor, and Patch components must be numeric.

The client‘s MAJOR and MINOR versions should equal to server's, otherwise, the zipper will be considered has break-change, the handshake will fail.

Impact

This is a break-change. It will not be possible to establish a connection with the zipper if the source/sfn does not send the version field.

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
yomo ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 8:13am

@fanweixiao fanweixiao changed the title Feat/version feat: version negotiation Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (6d8b913) 59.01% compared to head (1703e64) 59.40%.

Files Patch % Lines
core/server.go 76.47% 6 Missing and 2 partials ⚠️
pkg/frame-codec/y3codec/handshake_frame.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
+ Coverage   59.01%   59.40%   +0.38%     
==========================================
  Files          36       37       +1     
  Lines        2706     2754      +48     
==========================================
+ Hits         1597     1636      +39     
- Misses       1009     1015       +6     
- Partials      100      103       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fanweixiao fanweixiao added the merge later Go version or break changes block merge to current version label Oct 14, 2023
@woorui woorui merged commit 0ca2c1a into master Dec 15, 2023
7 checks passed
@woorui woorui deleted the feat/version branch December 15, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge later Go version or break changes block merge to current version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants