Support NavigationViews #17
Conversation
| override open func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(animated) | ||
| self.analyzer = ImageAnalyzer(delegate: self) |
There was a problem hiding this comment.
Sorry for the delay, I must have missed this! This implementation results in layoutSubviews and such being called again, which is not desirable. Is re-initializing ImageAnalyzer the best way to address navigation controllers?
There was a problem hiding this comment.
Omg. I made a mistake.
I needed the feature that the subview which has the card scanner should be called again, which consists of navigation views. The re-initializing code line is from my habbit. I tested it without the line.
There was a problem hiding this comment.
But anyway, thanks for this library. I'm using this very usefully.
There was a problem hiding this comment.
Also if you feel like this is not desirable, you can just close this pr. Thanks.
What about change
viewDidLoadtoviewWillAppear, re-initializing ImageAnalyzer for NavigationView?When users came back from the subview(result) to the root view(scanner view) in NavigationView, I think that
viewDidLoadis not gonna be called.