Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce locality counters for single shard tx. #13415

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Introduce locality counters for single shard tx. #13415

merged 2 commits into from
Jan 20, 2025

Conversation

dcherednik
Copy link
Member

TotalSingleShardTxCount - increases if tx touches the only one shard
NonLocalSingleShardTxCount - increases if tx touches the only one shard and this shard located on the different node

Changelog category

  • New feature

@dcherednik
Introduce locality counters for single shard tx.
ce4b1a9 
TotalSingleShardTxCount - increases if tx touches the only one shard
NonLocalSingleShardTxCount - increases if tx touches the only one shard and this shard located on the different node
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 17:51:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 67a4f8e has started.
⚪ 2025-01-15 17:51:57 UTC Artifacts will be uploaded here
⚪ 2025-01-15 17:55:02 UTC ya make is running...
🟡 2025-01-15 19:02:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27242 24731 0 7 2380 124

⚪ 2025-01-15 19:05:25 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 19:17:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
189 (only retried tests) 68 0 0 0 121

🟢 2025-01-15 19:17:57 UTC Build successful.
🟢 2025-01-15 19:18:18 UTC ydbd size 2.1 GiB changed* by +13.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ca6eab5 merge: 67a4f8e diff diff %
ydbd size 2 252 624 848 Bytes 2 252 639 016 Bytes +13.8 KiB +0.001%
ydbd stripped size 473 493 520 Bytes 473 495 504 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

⚪ 2025-01-15 17:53:00 UTC Pre-commit check linux-x86_64-release-asan for 67a4f8e has started.
⚪ 2025-01-15 17:53:04 UTC Artifacts will be uploaded here
⚪ 2025-01-15 17:55:59 UTC ya make is running...
🟡 2025-01-15 19:09:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13297 13239 0 22 10 26

⚪ 2025-01-15 19:10:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 19:25:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
96 (only retried tests) 68 0 1 3 24

⚪ 2025-01-15 19:25:42 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-15 19:37:26 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
51 (only retried tests) 25 0 0 1 25

🟢 2025-01-15 19:37:32 UTC Build successful.
🟢 2025-01-15 19:37:59 UTC ydbd size 3.6 GiB changed* by +27.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ca6eab5 merge: 67a4f8e diff diff %
ydbd size 3 903 073 088 Bytes 3 903 101 672 Bytes +27.9 KiB +0.001%
ydbd stripped size 1 362 738 288 Bytes 1 362 745 328 Bytes +6.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

⚪ 2025-01-20 12:34:43 UTC Pre-commit check linux-x86_64-release-asan for a9de766 has started.
⚪ 2025-01-20 12:34:54 UTC Artifacts will be uploaded here
⚪ 2025-01-20 12:38:06 UTC ya make is running...
🟡 2025-01-20 14:02:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13266 13220 0 10 7 29

⚪ 2025-01-20 14:03:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-20 14:16:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74 (only retried tests) 47 0 0 1 26

🟢 2025-01-20 14:16:09 UTC Build successful.
🟢 2025-01-20 14:16:36 UTC ydbd size 3.6 GiB changed* by +44.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 04f4156 merge: a9de766 diff diff %
ydbd size 3 852 980 728 Bytes 3 853 026 176 Bytes +44.4 KiB +0.001%
ydbd stripped size 1 346 195 888 Bytes 1 346 210 736 Bytes +14.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

⚪ 2025-01-20 12:34:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for a9de766 has started.
⚪ 2025-01-20 12:34:58 UTC Artifacts will be uploaded here
⚪ 2025-01-20 12:38:20 UTC ya make is running...
🟡 2025-01-20 14:02:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27540 25026 0 4 2380 130

⚪ 2025-01-20 14:04:55 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-20 14:16:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
189 (only retried tests) 65 0 1 0 123

⚪ 2025-01-20 14:16:56 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-20 14:28:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
178 (only retried tests) 57 0 0 0 121

🟢 2025-01-20 14:28:41 UTC Build successful.
🟢 2025-01-20 14:29:09 UTC ydbd size 2.1 GiB changed* by +20.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 04f4156 merge: a9de766 diff diff %
ydbd size 2 216 627 368 Bytes 2 216 648 248 Bytes +20.4 KiB +0.001%
ydbd stripped size 468 629 104 Bytes 468 631 440 Bytes +2.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik merged commit 1ad3712 into ydb-platform:main Jan 20, 2025
12 checks passed
the-ancient-1 pushed a commit to the-ancient-1/ydb that referenced this pull request Jan 21, 2025
@dcherednik @the-ancient-1
Introduce locality counters for single node tx. (ydb-platform#13415)
f3fca2a 
TotalSingleNodeReqCount    -     increases if tx touches the only one node (all shards located on the same node)
NonLocalSingleNodeReqCount - increases if tx touches the only one node and this node is same with session node (node where located kqp session and grpc request accepted)


### Changelog category <!-- remove all except one -->

* New feature
dcherednik added a commit to dcherednik/ydb that referenced this pull request Jan 21, 2025
@dcherednik
Introduce locality counters for single node tx. (ydb-platform#13415)
0a54179 
TotalSingleNodeReqCount    -     increases if tx touches the only one node (all shards located on the same node)
NonLocalSingleNodeReqCount - increases if tx touches the only one node and this node is same with session node (node where located kqp session and grpc request accepted)

* New feature
dcherednik added a commit that referenced this pull request Jan 22, 2025
@dcherednik
Introduce locality counters for single node tx. (#13415) (#13679)
cc68f4d
dcherednik added a commit to dcherednik/ydb that referenced this pull request Jan 22, 2025
@dcherednik
Introduce locality counters for single node tx. (ydb-platform#13415)
c085491 
TotalSingleNodeReqCount    -     increases if tx touches the only one node (all shards located on the same node)
NonLocalSingleNodeReqCount - increases if tx touches the only one node and this node is same with session node (node where located kqp session and grpc request accepted)

* New feature
dcherednik added a commit that referenced this pull request Jan 23, 2025
@dcherednik
Introduce locality counters for single node tx. (#13415) (#13735)
c84c920 
TotalSingleNodeReqCount    -     increases if tx touches the only one node (all shards located on the same node)
NonLocalSingleNodeReqCount - increases if tx touches the only one node and this node is same with session node (node where located kqp session and grpc request accepted)

* New feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulya-sidorina ulya-sidorina ulya-sidorina approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherednik @ulya-sidorina